- templatize default file

saltstack-formulas / bind-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html

Other

29 stars 117 forks source link

- templatize default file #45

Closed cybacolt closed 8 years ago

cybacolt commented 8 years ago

fix config.sls to match
add example to pillar.example

improvements regarding issue https://github.com/saltstack-formulas/bind-formula/issues/43 and PR https://github.com/saltstack-formulas/bind-formula/pull/44.

changes revert gracefully now on omission.

gravyboat commented 8 years ago

@cybacolt I added one line note just so we can try to make this clear for any user since I think the simple use of 4/6 without a bit more explanation might be confusing, other than that this is an awesome change! Let me know what you think about the documentation thing and I'll get this merged!

gravyboat commented 8 years ago

@cybacolt Also I don't know if you saw this: https://hacktoberfest.digitalocean.com/ but if you want a free shirt I think you've hit the requirement for October. Not sure if it's still open, but a nice bonus for doing these if it is! (Apparently they are sending emails on Nov. 2nd in the EST timezone)

cybacolt commented 8 years ago

@gravyboat doco change done, signed up for a free tshirt, but dont like my chances ! :)

gravyboat commented 8 years ago

Awesome thanks!