Fix cli.create conditional bug; update docs

saltstack-formulas / devstack-formula

Deployment lifecycle for Openstack Devstack via Salt. Good OSC CLI Support.

Other

4 stars 2 forks source link

Fix cli.create conditional bug; update docs #11

Closed noelmcloughlin closed 6 years ago

noelmcloughlin commented 6 years ago

This PR is for two reasons. Firstly there is a bug in cli.state create where onlyif is used instead of unless - this was missed during cut+paste during editing. The second thing I would like is to ensure variables in pillar.example and README use devstack_ prefix to help avoid Jinja variable name collision. This is minor update to the formula. Thanks.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

pull-assistant[bot] commented 4 years ago

Best reviewed: commit by commit

Optimal code review plan (1 warning)

Update examples (and defaults) to reduce chance of Jinja name collisio...

> `devstack/defaults.yaml` 67% changes removed in fix wrong conditiona...

fix wrong conditional (cut+pasted)

Powered by Pull Assistant. Last update 1e82c91 ... e5bef45. Read the comment docs.