Adapt templates to be compatible with python3

saltstack-formulas / dhcpd-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html

Other

8 stars 56 forks source link

Adapt templates to be compatible with python3 #24

Closed aaannz closed 6 years ago

aaannz commented 6 years ago

replace all dict.has_key by 'key in dict'

0xf10e commented 6 years ago

Hmm… does this work on RHEL/CentOS 6? The dict.has_key() stuff looks like something for annoyingly old versions of jinja to me…

aaannz commented 6 years ago

That is why I replace it by key in dict

aaannz commented 6 years ago

Just in case I misunderstood your question. I did not test it on RHEL/CentOS6. I did test it in SLES12 SP2 and SLES12 SP3. Former with salt 2016.11.4, later with salt 2017.7.2. Head version (without changes in this PR) did not work with SLES12SP3 + salt 2017.7.2.

aaannz commented 6 years ago

I rebased the changes. It there anything more I can do?

javierbertoli commented 6 years ago

I merged it as the changes LGTM. Thanks @aaannz!