search

saltstack-formulas / dhcpd-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
8 stars 56 forks source link

Implement QA testing #25

Closed mthibaut closed 5 years ago

mthibaut commented 6 years ago

*) Some fixes in pillar.example used to produce a dhcpd.conf:

/etc/dhcp/dhcpd.conf line 40: primary failover server must have hba or split. /etc/dhcp/dhcpd.conf line 41: primary failover server must have mclt. /etc/dhcp/dhcpd.conf line 65: . (46): expecting IP address or hostname option domain-name-servers n,s,1,.

*) Added kitchen config (.kitchen.yml) and ignoring kitchen temporary files (.gitignore).

*) Created test.sls that checks config file for syntax errors.

mthibaut commented 6 years ago

Fixed all comments from reviewers.

mthibaut commented 6 years ago

I see your point. It's just a bit frustrating because I have a ton of changes I want to get accepted ;). I'll try and limit them by feature and keep the rewrites separate.

mthibaut commented 6 years ago

Submitted issue against saltstack/salt for the check_cmd issue which requires the mini-script workaround in dhcpd/config.sls:

https://github.com/saltstack/salt/issues/46189