saltstack-formulas / dhcpd-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
8 stars 56 forks source link

feat: add some non "options" prefixed options #61

Open ekacnet opened 1 year ago

ekacnet commented 1 year ago

Adding option like filename and next-server for the match section. There is a bit of refactoring done as well that could be extended to avoid repeating the options stuff everywhere... It can be used in this kind of situation:

class "x32_uefi" {
    match if option clientarch = 00:06;
    filename "/tftpboot/bootia32.efi";
    next-server 1.2.3.4;
}

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

match sections of the DHCP config can have options name that don't start with options for instance filename or next-server

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

ekacnet commented 1 year ago

Issues on gentoo seems unrelated to my changes, it seems the test environment is not working as expected anymore.

ekacnet commented 1 year ago

@myii you seems to be active on other pull requests and on this repository, can you have a look at this PR ?

sticky-note commented 1 year ago

LGTM