Open ekacnet opened 1 year ago
Issues on gentoo seems unrelated to my changes, it seems the test environment is not working as expected anymore.
@myii you seems to be active on other pull requests and on this repository, can you have a look at this PR ?
LGTM
Adding option like filename and next-server for the match section. There is a bit of refactoring done as well that could be extended to avoid repeating the options stuff everywhere... It can be used in this kind of situation:
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
Describe the changes you're proposing
match
sections of the DHCP config can have options name that don't start withoptions
for instancefilename
ornext-server
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context