ddns-rev-domainname is added at the top level of the configuration and in the subnet section too.
ddns-domainname is added to the subnet section as well because it's possible to do so in configuration (ie. supose that you want hosts in
a given subnet to have a different domain, for instance iot.foo.com).
ddns-hostname is added for host section because actually quite handy to fix broken names that some client are generating.
PR progress checklist (to be filled in by reviewers)
[ ] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed
What type of PR is this?
Primary type
[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[X] [feat] A new feature
[ ] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
Secondary type
[ ] [docs] Documentation changes
[ ] [test] Adding missing or correcting existing tests
Does this PR introduce a BREAKING CHANGE?
No.
Related issues and/or pull requests
Describe the changes you're proposing
Some ddns related options were not configurable, either in the main section or in the subnet section or host section.
In particular the ddns-rev-domain is allowed now both in the main section and in the subnet one.
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
[ ] Updated the README (e.g. Available states).
[ ] Updated pillar.example.
Testing checklist
[ ] Included in Kitchen (i.e. under state_top).
[ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
sticky-note
commented
1 year ago
ddns-rev-domainnameis added at the top level of the configuration and in the subnet section too.ddns-domainnameis added to the subnet section as well because it's possible to do so in configuration (ie. supose that you want hosts in a given subnet to have a different domain, for instance iot.foo.com).ddns-hostnameis added for host section because actually quite handy to fix broken names that some client are generating.PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
Describe the changes you're proposing
Some ddns related options were not configurable, either in the main section or in the subnet section or host section. In particular the
ddns-rev-domainis allowed now both in the main section and in the subnet one.Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context