search

saltstack-formulas / django-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Apache License 2.0
42 stars 26 forks source link

django-formula: next generation #8

Open bebosudo opened 5 years ago

bebosudo commented 5 years ago

Hi all, I wrote another django-formula, which provides more options to customize a django webapp. Moreover, I wrote a working example of deployment.

https://github.com/bebosudo/django-formula/ https://groups.google.com/forum/#!topic/salt-users/rMeG9VirEns

I propose to add it as a ng version, as in the postgres-formula. What do you think?

aboe76 commented 5 years ago

@bebosudo sorry to see this issue, so late...

Will look into it.

bebosudo commented 5 years ago

Hi @aboe76, I'd like to extend the example further with a pipenv section. Feel free to comment my fork.

bebosudo commented 5 years ago

@aboe76 any news?

myii commented 5 years ago

@bebosudo Please continue your good work. We're making substantial changes across all SaltStack Formulas right now, to improve the quality and consistency of formulas. For example of some of the changes we're working through, please see https://github.com/saltstack-formulas/template-formula/issues/21.

Once we've managed to start applying automatic release tagging and the other basic structures, we can look at how to incorporate ng formulas. For another example of a formula working towards this, refer to the conversation surrounding the comment: https://github.com/saltstack-formulas/apache-formula/pull/251#issuecomment-464841346.

aboe76 commented 5 years ago

@bebosudo, @myii is right, we are changing the saltstack-formulas hopefully for the better to accomodate these kind of changes, with semver solution, instead of ng

myii commented 5 years ago

@aboe76 Our changes are going to take some time, perhaps we should put this in a new develop-v1.0.0 branch, like has been done for the apache-formula? One other thought about this (for both formulas) -- don't we want to set this new branch as the default, so that PRs are provided for the new branch?

aboe76 commented 5 years ago

@myii I see no problem with that.

myii commented 5 years ago

Thanks, @aboe76. @bebosudo OK, I've created that branch. Feel free to "replace" it with your formula in a new PR.

myii commented 4 years ago

@bebosudo Are you still interesting in providing this? We could continue with the branch or we could even implement semantic-release in this formula, to make it available immediately.

bebosudo commented 4 years ago

Hi, I'm still interested in developing that formula; I'll try to find time this week.

myii commented 4 years ago

@bebosudo Thanks, I'll try to get semantic-release implemented before then, so that we can have a cleaner conversion.

myii commented 4 years ago

@bebosudo OK, semantic-release has been merged in #9 and I've removed the extra branch develop-v1.0.0. I'll start the deprecation notices soon, so that any existing users are informed that the formula is about to be significantly modified.

myii commented 4 years ago

Another reason to get the current formula replaced: #11.