fix(compose-ng): fix ports, volumes, restart policy, add privileged mode

japtain-cack commented 4 years ago

PR progress checklist (to be filled in by reviewers)

[ ] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Primary type

[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[ ] [feat] A new feature
[x] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[ ] [docs] Documentation changes
[ ] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

Closes #240

Describe the changes you're proposing

I'm not sure if the docker_container state changed, but the existing code doesn't work for me. Getting issues as described in the linked issue above. I have added the necessary changes and this is now working in my environment consistently.

Pillar / config required to test the proposed changes

Pillar should be the same

Debug log showing how the proposed changes work

Documentation checklist

[ ] Updated the README (e.g. Available states).
[ ] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

Additional context

myii commented 4 years ago

@japtain-cack Thanks for preparing this fix. I've asked @kuznetsov420 (from #240) to test it, if possible.

CC: @noelmcloughlin.

kuznetsov420 commented 4 years ago

@myii @japtain-cack All looks good now. I've got correct port and volume bindings after state applying

myii commented 4 years ago

Thanks for confirming that @kuznetsov420. Just waiting for some feedback from @noelmcloughlin.

If there's not a response soon, please ping me again @japtain-cack. The debian-9 failure is unrelated to this PR but the commit message should be formatted according to the contributing guidelines, in order to ensure a release is created:

https://travis-ci.com/github/saltstack-formulas/docker-formula/jobs/311568679#L370-L375

So the message could be changed to something like:

-fixing ports, volumes, restart policy, and adding privileged mode
+fix(compose-ng): fix ports, volumes, restart policy, add privileged mode

That's just on the 72-character limit as well!

myii commented 4 years ago

Thanks @japtain-cack -- merged.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 0.43.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

noelmcloughlin commented 4 years ago

Great work @japtain-cack Sorry for missing the review request @myii

saltstack-formulas / docker-formula