Added few options to containers

marek-knappe commented 4 years ago

This change just adding some options that are supported by salt docker module

PR progress checklist (to be filled in by reviewers)

[X] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Primary type

[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[X] [feat] A new feature
[ ] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[X] [docs] Documentation changes
[ ] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

Describe the changes you're proposing

I added fields i needed for docker-compose, there is few more that probably will need to be added in the future as they are not supported by current formula

Pillar / config required to test the proposed changes

Changed example pillar to incorporate changes

Debug log showing how the proposed changes work

Documentation checklist

[X] Updated the README (e.g. Available states).
[X] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

Additional context

pull-assistant[bot] commented 4 years ago

Best reviewed: commit by commit

Optimal code review plan

Added few options to containers: working_dir, volume_driver, userns_mo...

Powered by Pull Assistant. Last update a569632 ... a569632. Read the comment docs.

myii commented 4 years ago

Merged, thanks for this @marek-knappe. Just one issue encountered, we're using semantic-release on many of our repos, so the commit message formatting is important, as mentioned in the contributing guidelines. Since there was only one commit, I was able to override the commit message upon merging:

-Added few options to containers: working_dir, volume_driver, userns_mode, user
+feat(compose-ng): support working_dir, volume_driver, userns_mode & user

marek-knappe commented 4 years ago

Merged, thanks for this @marek-knappe. Just one issue encountered, we're using semantic-release on many of our repos, so the commit message formatting is important, as mentioned in the contributing guidelines. Since there was only one commit, I was able to override the commit message upon merging:
-Added few options to containers: working_dir, volume_driver, userns_mode, user
+feat(compose-ng): support working_dir, volume_driver, userns_mode & user

Thanks - i was reading instructions and saw failed messages, but i thought it's about documentation here, not the commit. Thank you!

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 0.44.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

saltstack-formulas / docker-formula