saltstack-formulas / docker-formula

Install and set up Docker
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
136 stars 330 forks source link

fix(cent7): fixes for centos7 #255

Closed noelmcloughlin closed 4 years ago

noelmcloughlin commented 4 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

The formula was failing on CentOS7. This PR adds some changes which helped get formula passing.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

[vagrant@localhost ~]$ sudo salt-call state.highstate --local
[ERROR   ] Invalid input for repack_dictlist, data passed is not a list ({'docker-ce': '3:19.03.13-3.el7'})
local:
----------
          ID: docker-package-dependencies
    Function: pkg.installed
      Result: True
     Comment: 3 targeted packages were installed/updated.
     Started: 08:21:36.636199
    Duration: 31843.763 ms
     Changes:
              ----------
              elfutils:
                  ----------
                  new:
                      0.176-4.el7
                  old:
              emacs-filesystem:
                  ----------
                  new:
                      1:24.3-23.el7
                  old:
              gdb:
                  ----------
                  new:
                      7.6.1-119.el7
                  old:
              patch:
                  ----------
                  new:
                      2.7.1-12.el7_7
                  old:
              perl-Thread-Queue:
                  ----------
                  new:
                      3.02-2.el7
                  old:
              python-backports:
                  ----------
                  new:
                      1.0-8.el7
                  old:
              python-backports-ssl_match_hostname:
                  ----------
                  new:
                      3.5.0.1-1.el7
                  old:
              python-ipaddress:
                  ----------
                  new:
                      1.0.16-2.el7
                  old:
              python-setuptools:
                  ----------
                  new:
                      0.9.8-7.el7
                  old:
              python2-pip:
                  ----------
                  new:
                      8.1.2-14.el7
                  old:
              rpm-build:
                  ----------
                  new:
                      4.11.3-43.el7
                  old:
              rpmdevtools:
                  ----------
                  new:
                      8.3-5.el7
                  old:
              unzip:
                  ----------
                  new:
                      6.0-21.el7
                  old:
              yum-plugin-versionlock:
                  ----------
                  new:
                      1.1.31-54.el7_8
                  old:
----------
          ID: docker-package-repository
    Function: pkgrepo.managed
        Name: docker-ce-stable
      Result: True
     Comment: Configured package repo 'docker-ce-stable'
     Started: 08:22:08.513691
    Duration: 21608.311 ms
     Changes:
              ----------
              repo:
                  docker-ce-stable
----------
          ID: docker-package
    Function: pkg.installed
        Name: docker-ce
      Result: True
     Comment: 1 targeted package was installed/updated.
     Started: 08:22:30.125793
    Duration: 179796.736 ms
     Changes:
              ----------
              audit-libs-python:
                  ----------
                  new:
                      2.8.5-4.el7
                  old:
              checkpolicy:
                  ----------
                  new:
                      2.5-8.el7
                  old:
              container-selinux:
                  ----------
                  new:
                      2:2.119.2-1.911c772.el7_8
                  old:
              containerd.io:
                  ----------
                  new:
                      1.3.7-3.1.el7
                  old:
              docker-ce:
                  ----------
                  new:
                      3:19.03.13-3.el7
                  old:
              docker-ce-cli:
                  ----------
                  new:
                      1:19.03.13-3.el7
                  old:
              gpg-pubkey.(none):
                  ----------
                  new:
                      352c64e5-52ae6884,621e9f35-58adea78,de57bfbe-53a9be98,f4a80eb5-53a7ff4b
                  old:
                      352c64e5-52ae6884,de57bfbe-53a9be98,f4a80eb5-53a7ff4b
              libcgroup:
                  ----------
                  new:
                      0.41-21.el7
                  old:
              libsemanage-python:
                  ----------
                  new:
                      2.5-14.el7
                  old:
              policycoreutils-python:
                  ----------
                  new:
                      2.5-34.el7
                  old:
              python-IPy:
                  ----------
                  new:
                      0.75-6.el7
                  old:
              setools-libs:
                  ----------
                  new:
                      3.3.8-4.el7
                  old:
----------
          ID: docker-config
    Function: file.managed
        Name: /etc/default/docker
      Result: True
     Comment: File /etc/default/docker updated
     Started: 08:25:29.933882
    Duration: 114.84 ms
     Changes:
              ----------
              diff:
                  New file
              mode:
                  0644
----------
          ID: docker-service
    Function: service.running
        Name: docker
      Result: True
     Comment: Service docker has been enabled, and is running
     Started: 08:25:30.070943
    Duration: 4563.795 ms
     Changes:
              ----------
              docker:
                  True
----------
          ID: docker-install-docker-service-not-running-notify
    Function: test.show_notification
      Result: True
     Comment: State was not run because onfail req did not change
     Started: 08:25:34.637016
    Duration: 0.006 ms
     Changes:
----------
          ID: docker-install-docker-service-not-running-notify
    Function: service.enabled
        Name: docker
      Result: True
     Comment: State was not run because onfail req did not change
     Started: 08:25:34.637256
    Duration: 0.002 ms
     Changes:
----------
          ID: docker-py
    Function: pip.installed
        Name: docker
      Result: True
     Comment: All packages were successfully installed
     Started: 08:26:02.003343
    Duration: 10921.993 ms
     Changes:
              ----------
              docker==4.3.1:
                  Installed

Summary for local
------------
Succeeded: 8 (changed=6)
Failed:    0
------------
Total states run:     8
noelmcloughlin commented 4 years ago

I've ran this a few times on CentOS7 and looks okay. Cent8 is different issue #243 Selfie merging.

saltstack-formulas-travis commented 3 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: