dockerd systemctl service - support for LimitNOFILE parameter

mszumski-pcx commented 3 years ago

PR progress checklist (to be filled in by reviewers)

[x] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Primary type

[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[x] [feat] A new feature
[ ] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[ ] [docs] Documentation changes
[ ] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

Describe the changes you're proposing

This PR adds systemd LimitNOFILE (Number of File Descriptors ulimit -n) support.

Pillar / config required to test the proposed changes

docker:
  pkg:
    docker:
      service:
        limitnofile: 65000

Debug log showing how the proposed changes work

Documentation checklist

[ ] Updated the README (e.g. Available states).
[ ] Updated pillar.example.

Testing checklist

[x] Included in Kitchen (i.e. under state_top).
[ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

Additional context

noelmcloughlin commented 3 years ago

Hi @mszumski-pcx could you fix conflicts. Thanks for the PR.

noelmcloughlin commented 3 years ago

Also change the commit message to feat(systemd): support for LimitNOFILE in service or whatever, so Linters pass.

noelmcloughlin commented 3 years ago

@mszumski-pcx happy new year. Can you get PR ready for merge?

noelmcloughlin commented 3 years ago

conflicts - replaced with https://github.com/saltstack-formulas/docker-formula/pull/302

saltstack-formulas / docker-formula