search

saltstack-formulas / docker-formula

Install and set up Docker
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
136 stars 330 forks source link

Import YAML with context #288

Open Lucianovici opened 3 years ago

Lucianovici commented 3 years ago

Import with context to avoid errors like:

[CRITICAL] Rendering SLS ... failed: Jinja variable 'grains' is undefined
[CRITICAL] Rendering SLS ... failed: Jinja variable 'salt' is undefined
myii commented 3 years ago

@Lucianovici When amending the commit, please update the commit message for semantic-release purposes:

-Import YAML with context
+fix(map.jinja): import YAML with context
myii commented 3 years ago

@danny-smit I see you have some PRs active for this formula, which would benefit from this fix being applied. How about we get this PR merged soon, as one example of what would need to be done in case we're forced to patch the 30+ formulas?

danny-smit commented 3 years ago

@myii Thanks, that sounds very good to me. Can I help with that?

myii commented 3 years ago

@myii Thanks, that sounds very good to me. Can I help with that?

@danny-smit Ah, I've just noticed that this PR was started from the contributor's master branch, so I don't think I can do the usual process of amending the PR myself. There are other ways using git but those don't work well on the GitHub side of things. Let's hope @Lucianovici is able to adjust the PR soon, so that we can get it merged.

myii commented 3 years ago

@danny-smit Actually, are you able to commit my suggestion from the review above? If so, I can finish the rest upon squash-merging this PR.

danny-smit commented 3 years ago

@myii No, I don't have permission to add commits.

myii commented 3 years ago

@myii No, I don't have permission to add commits.

I've been chatting to @javierbertoli -- we're thinking about rebuilding the master images to the last commit before this problem started, keeping it there until there's some clarity from the Salt devs. If we do that, we can simply rerun the CI on your PRs and they should just work.

myii commented 3 years ago

@danny-smit So we've started fixing the images and most are working now. You can see the CI re-run of #289 here:

It's actually wider-reaching than just the master builds. It's actually all the builds installing Salt using git (i.e. pip), so I'm in the process of fixing those as well.

danny-smit commented 3 years ago

@myii Nice work. The tests of the CI re-runs are working much better now!