Closed danny-smit closed 3 years ago
@noelmcloughlin Thanks for reviewing @noelmcloughlin and @myii What is the correct procedure to get this pull request merged?
I just wait a day or two for any objections - or someone else to take initiative in merging. Happy to merge now!!
:tada: This PR is included in version 2.0.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
@noelmcloughlin Thanks for explaining and merging!
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
Follow up of https://github.com/saltstack-formulas/docker-formula/pull/282
Describe the changes you're proposing
Ensure that the docker daemon is reloaded when changes are applied to the daemon.json.
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
The 'watch' added to the 'service.running' state causes the service to be restarted:
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context
Current tests execute a clean installation. The problem occurs when salt runs a second time with configuration changes for the daemon.json. It is difficult to get this included in the tests.