feat(ng): manage docker heathcheck in ng state - Githubissues

saltstack-formulas / docker-formula

Install and set up Docker

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html

Other

136 stars 330 forks source link

feat(ng): manage docker heathcheck in ng state #309

Open kartnico opened 2 years ago

kartnico commented 2 years ago

PR progress checklist (to be filled in by reviewers)

[X] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

Primary type

[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[X] [feat] A new feature
[ ] [fix] A bug fix
[ ] [perf] A code change that improves performance
[X] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[ ] [docs] Documentation changes
[ ] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Manage healthcheck capabilities in docker.compose.ng

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

[X] Updated the README (e.g. Available states).
[X] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

Additional context

Absent documentation for docker healthcheck in Salt : #53511

noelmcloughlin commented 2 years ago

Pre-commit checks are failing.

./pillar.example
  196:23    error    too many spaces inside braces  (braces)
  196:34    error    too many spaces inside braces  (braces)
  197:22    error    too many spaces inside braces  (braces)
  197:33    error    too many spaces inside braces  (braces)
./test/salt/pillar/archive.sls
  196:23    error    too many spaces inside braces  (braces)
  196:34    error    too many spaces inside braces  (braces)
  197:22    error    too many spaces inside braces  (braces)
  197:33    error    too many spaces inside braces  (braces)