saltstack-formulas / docker-formula

Install and set up Docker
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
136 stars 330 forks source link

feat(debian): use repository keyring instead of key_id #312

Closed javierbertoli closed 2 years ago

javierbertoli commented 2 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Debian family is deprecating the use of GPG keys (managed through apt-key) in favor of keyrings. This PR adds the repositorykeyring when installing from the official repository, and rewrites the sources.list file accordingly.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

noelmcloughlin commented 2 years ago

I think Tumbleweed is failing because of https://progress.opensuse.org/issues/104193#change-475218 so you could disable that platform - or try a workaround: sed -i 's|download.opensuse|mirrorcache.opensuse|g' *.repo

saltstack-formulas-travis commented 2 years ago

:tada: This PR is included in version 2.4.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: