Open benfiedler opened 2 years ago
could you make a PR with your modification ?
Thank's in advance
it's created - my apologies, this is my first PR
In my previous PR the commit message did not meet standards. This one does - https://github.com/saltstack-formulas/docker-formula/pull/330
My setup
Formula version: latest master
Versions reports (master & minion)
Salt Version: Salt: 3004.1
Pillar / config used
Bug details
Describe the bug
Hi,
I have recently switched over to using this formula, and it seems to work great except for one thing:
In my testing across recent *nixes (Debian-11 / Ubuntu-20.04 / CentOS Stream-8), the environ_file is unutilized by upstream packages and ignored by the docker systemd service.
Steps to reproduce the bug
Expected behaviour
Docker should be pulling images using the proxy
Attempts to fix the bug
I have come up with a simple fix to the formula which if an environ is defined on *nix, opts to create a drop-in docker.service.d/override.conf using states.ini_manage which is simply:
Detected changes to the dropin file will do a
systemctl daemon-reload
and also restart the service. I also fixed service.running to enforce changes to the environ file by restarting the docker service.My fork with fixes: https://github.com/benfiedler/docker-formula/commit/b131392460a8f0ff4013e07691c87e283ab71dca
Additional context