search

saltstack-formulas / exim-formula

Setup and configure the exim mail server.
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
9 stars 15 forks source link

[FEATURE] Treat other_hostnames and local_interfaces as list #14

Closed n-rodriguez closed 5 years ago

myii commented 5 years ago

Optional: How can this template be improved?

\

@n-rodriguez: What template?!

n-rodriguez commented 5 years ago

?

myii commented 5 years ago

@n-rodriguez I was joking with you. That was your response to the feature_request template that was nicely laid out!

n-rodriguez commented 5 years ago

@n-rodriguez I was joking with you. That was your response to the feature_request template that was nicely laid out!

Ok ^^

myii commented 5 years ago

@n-rodriguez The template did show up, didn't it? Or is there some underlying issue we need to fix?

n-rodriguez commented 5 years ago

@n-rodriguez The template did show up, didn't it?

It did!

myii commented 5 years ago

OK, thanks for that confirmation. Sorry for the noise!

n-rodriguez commented 5 years ago

OK, thanks for that confirmation. Sorry for the noise!

No problem. Tell me when you're done with https://github.com/saltstack-formulas/exim-formula/pull/13. I've got another one to submit :)

myii commented 5 years ago

No problem. Tell me when you're done with #13. I've got another one to submit :)

@n-rodriguez You're definitely keeping me busy! I'll try to look at it within the next day.

myii commented 5 years ago

@n-rodriguez I just tried to ping you on IRC. Since we're deeply entwined with all of these PRs, can we get some sort of direct contact working? It would be easier to deal with certain issues.

One question, completely off-topic for this issue but at an organisational level: what Ruby linter would you recommend that we include in the Travis lint stage, for our InSpec files?

myii commented 5 years ago

@n-rodriguez I've started testing running linting checks with rubocop and it's looking good. Any thoughts?

n-rodriguez commented 5 years ago

Any thoughts?

rubocop is the way to go :+1:

myii commented 5 years ago

@n-rodriguez These are the changes for the template-formula -- what do you think?

n-rodriguez commented 5 years ago

@n-rodriguez These are the changes for the template-formula -- what do you think?

I'm not for running linters first. If linters don't pass, tests don't run :/

Why not adding rubocop in the Gemfile?

myii commented 5 years ago

I'm not for running linters first. If linters don't pass, tests don't run :/

@n-rodriguez The linters is just an idea of mine, more to do with a pragmatic solution to our limited shared resources on Travis. Many times, we've got complete test runs completing, even though each of them is going to fail because of lint issues. That's not a finalised plan, though.

Why not adding rubocop in the Gemfile?

Yes, that will be the final plan, I was just messing around for now.

The important thing: what about the actual changes made? Are you happy with those or is there some things that could be done differently?

saltstack-formulas-travis commented 5 years ago

:tada: This issue has been resolved in version 0.6.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: