feat(config): allow to manage config files under CONFDIR

[javierbertoli]

PR progress checklist (to be filled in by reviewers)

• [ ] Changes to documentation are appropriate (or tick if not required)
• [ ] Changes to tests are appropriate (or tick if not required)
• [ ] Reviews completed

---

What type of PR is this?

Primary type

• [ ] [build] Changes related to the build system
• [ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
• [ ] [ci] Changes to the continuous integration configuration
• [x] [feat] A new feature
• [x] [fix] A bug fix
• [ ] [perf] A code change that improves performance
• [ ] [refactor] A code change that neither fixes a bug nor adds a feature
• [ ] [revert] A change used to revert a previous commit
• [ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

• [ ] [docs] Documentation changes
• [ ] [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Should fix #17

Describe the changes you're proposing

Added the possibility to manage files under the main config dir (/etc/exim4) through pillars, in a backward compatible way: simply added a base entry in exim:sub_dirs variable which manages the files under that dir, using the same logic as it does with other files.

Also, fixed an issue where the update-exim4.conf was not triggered when the config files changed: added a watch in the service, which triggers a rebuild and reload of the config

Pillar / config required to test the proposed changes

Added examples and tests.

Debug log showing how the proposed changes work

Documentation checklist

• [ ] Updated the README (e.g. Available states).
• [ ] Updated pillar.example.

Testing checklist

• [ ] Included in Kitchen (i.e. under state_top).
• [ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
• [ ] Updated the relevant test pillar.

Additional context

[pull-assistant[bot]]

Best reviewed: commit by commit

---

Optimal code review plan (1 warning)

feat(config): allow to manage config files under CONFDIR

> `exim/config/file.sls` 67% changes removed in fix(service): reorde...

     feat(service): reload service instead of restarting it      fix(service): reorder watchers to match org defaults

Powered by Pull Assistant. Last update e3e88e4 ... 4ac38d8. Read the comment docs.

[myii]

@javierbertoli Quick initial review. First issue is that some parts of this is related to the bug discussed here:

• https://tree.taiga.io/project/myii-saltstack-formulas/us/176

So I'll mention the issues for that inline.

[saltstack-formulas-travis]

:tada: This PR is included in version 0.7.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: