search

saltstack-formulas / gitlab-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Apache License 2.0
29 stars 49 forks source link

runner: replace symlink with cp for upstart #13

Closed Lendar closed 9 years ago

Lendar commented 9 years ago

https://bugs.launchpad.net/upstart/+bug/665022/comments/3

This commit fixes error: 

Service gitlab-runner is already enabled, and is dead
iggy commented 9 years ago

You might want to add a force: True in there so it gets updated if it exists.

Lendar commented 9 years ago

@iggy you're right, this fix should prevent crash if it is applied to existing symlink.

By the way, other states need the same fix.

My use case: I have Ubuntu 14.04, and I run just one state: gitlab.runner on micro instance. But I guess most people have different use case. 10+ states are run, one of the states writes file to /etc/init, so upstart scans the whole dir and finds the symlink.

iggy commented 9 years ago

Thanks for the fix.

If you see other formulas that do the same thing, open issues/PRs for those.