search

saltstack-formulas / gitlab-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Apache License 2.0
29 stars 49 forks source link

Updated the packages so it relies on git, added that dep as an item in the readme. #4

Closed gravyboat closed 10 years ago

gravyboat commented 10 years ago

I believe this resolves the associated issue, any concerns? @viq?

viq commented 10 years ago

I'm a bit worried that the aforementioned git-formula wasn't tested on anything but Ubuntu. If someone beats me to testing that it works on CentOS and Debian then I don't have anything against it.

whiteinge commented 10 years ago

Hm, yeah. That formula definitely needs some love.

gravyboat commented 10 years ago

@viq, the portions of the git formula I'm using should be OS agnostic, it just does a check and then installs the package.

viq commented 10 years ago

@gravyboat I was thinking that somewhere the package was named git-core, but looks like my memory was failing me - I just checked and both on CentOS and Debian package name is git, which is what this formula does. So yes, this change does look acceptable to me.

gravyboat commented 10 years ago

@whiteinge can you merge this when you get a moment since we have @viq's sign off?

whiteinge commented 10 years ago

I remember the git package being named git-core as well. I don't remember where though. Perhaps that was Ubuntu pre-Precise? Anyhoo...merged.