search

saltstack-formulas / graphite-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
15 stars 41 forks source link

whisper directory perms should only be set on create #8

Open iggy opened 9 years ago

iggy commented 9 years ago

https://github.com/saltstack-formulas/graphite-formula/blob/master/graphite/init.sls#L86

If you have data already in that directory, the recurse can take forever.

sroegner commented 9 years ago

Fair point - shouldn't we just get rid of that statement altogether?

iggy commented 9 years ago

I was thinking something like the following. I don't know how much of the shell is available for onlyif calls though (or I would have just done a PR ;) onlyif: [ ! -d {{ whisperdir }} ]

sroegner commented 9 years ago

That would work but looking at the code again i'd think we'll just have to get rid of the recurse attribute - then it should only create the whisper dir if needed but nothing more. Will need to get a test setup together for this - if you need this expedited you can send me a PR.