copy keepalived config jinja - Githubissues

saltstack-formulas / haproxy-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html

Other

28 stars 122 forks source link

copy keepalived config jinja #66

Open kungfoome opened 7 years ago

kungfoome commented 7 years ago

Would it be better to base the jinja template off the keepalived formula? https://github.com/saltstack-formulas/keepalived-formula/blob/master/keepalived/templates/config.jinja

It seems right now that all the options need to be maintained, but you can't easily add any if they are missing.

Problems may arise from certain settings with periods, which will probably need to be maintained. Example:

tune.ssl.maxrecord
tune.ssl.default-dh-param
tune.ssl.ssl-ctx-cache-size

Are there any foreseeable issues with doing it this way?

johnkeates commented 7 years ago

While I agree that a programmatic expansion of a YAML tree into the HAProxy style config is preferred, I don't know (as you already suggest) what the impact would be on the output. We'd have to make some sort of CI check for this to see if all the config we want keeps working.