saltstack-formulas / hostsfile-formula

Use minion IDs to keep /etc/hosts and hostnames consistent for clusters without DNS
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
33 stars 89 forks source link

use salt['pillar.get'] to avoid bogus entries. Fixes #26 #30

Closed wonko21 closed 4 years ago

wonko21 commented 4 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Fixes #26.

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

myii commented 4 years ago

Thanks for providing this, @wonko21. This will fail the commitlint check due to our commit message formatting requirements (see the contributing guidelines), but I can fix that upon merging this PR once the rest of the tests complete.

wonko21 commented 4 years ago

Sorry about the commitlint. I only saw the guidlines after the fact.

myii commented 4 years ago

@wonko21 Not a problem, thanks for the fix!

myii commented 4 years ago

@wonko21 Merged, with the fixed commit message (as you can see when this reaches the release notes and changelog).

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 0.8.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: