search

saltstack-formulas / hostsfile-formula

Use minion IDs to keep /etc/hosts and hostnames consistent for clusters without DNS
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
33 stars 89 forks source link

Typo in state #39

Closed ricariel closed 2 years ago

ricariel commented 2 years ago 
$ diff --git a/hostsfile/hostname.sls b/hostsfile/hostname.sls
index 60a6671..d137124 100644
--- a/hostsfile/hostname.sls
+++ b/hostsfile/hostname.sls
@@ -33,7 +33,7 @@ hostsfile-etc-sysconfig-network:
     - backup: false
 {% endif %}
     - onchanges_in:
-      - cmd: set-fqdn
+      - cmd: hostsfile-set-fqdn

 hostsfile-{{ fqdn }}-hosts-entry:
   host.present:
myii commented 2 years ago

Thanks for the report, @ricariel.

This was introduced in #36, which then had the state ID adjusted in #37. @noelmcloughlin, would you like to resolve this either way?

In fact, there's even a comment about it from @aboe76 here.

noelmcloughlin commented 2 years ago

Thanks @ricariel @myii PR raised https://github.com/saltstack-formulas/hostsfile-formula/issues/39

saltstack-formulas-travis commented 2 years ago

:tada: This issue has been resolved in version 0.9.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: