saltstack-formulas / hostsfile-formula

Use minion IDs to keep /etc/hosts and hostnames consistent for clusters without DNS
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
33 stars 89 forks source link

Unused line of code, remove or update readme #7

Closed samos123 closed 9 years ago

samos123 commented 9 years ago

The following line seems no longer being used?

{%- set if = grains['maintain_hostsfile_interface'] %}

If it's still in use we should update readme, if it's not in use anymore maybe we can remove it. also setting a variable name to be if is really confusing as if can also be an if statement.

Link to code: https://github.com/saltstack-formulas/hostsfile-formula/blob/master/hostsfile/init.sls#L15

wwentland commented 9 years ago

Oh dear .... if as variable name is really quite suboptimal and I see no reason why we wouldn't want to remove that line as it is no longer used.

samos123 commented 9 years ago

Ok pull request incoming, i thought it was maybe some jinja magic I didn't understood haha.

aboe76 commented 9 years ago

@samos123 can this issue be closed? because of merge #8