search

saltstack-formulas / icinga2-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
19 stars 28 forks source link

Refactoring #17

Closed alxwr closed 6 years ago

alxwr commented 7 years ago

@martinhoefling I broke the formula into smaller, independently reusable parts, hopefully while keeping backwards compatibility.

The following components seem to have ceased functioning: (At least I couldn't get them to work.)

Furthermore I'm not sure whether it makes sense to keep these: (Is there still a use-case for running Icinga2 stanalone?)

Frankly I'm not sure whether icinga-web.sls, icinga-web2.sls and classicui.sls worked for anybody within the last months. (No offense! Just trying to assess the impact of this PR.) Therefore we could risk dropping all legacy code in order to increase maintainability.

Would that be OK for you? (I'm totally fine with "Got no time, do whatever you see fit!" too.)

Next things I'll be working on are FreeBSD and (external) MySQL/MariaDB support.

alxwr commented 6 years ago

@martinhoefling @aboe76 No reaction since August. I'll go ahead and merge this PR in a few days if there is no veto. :-)

martinhoefling commented 6 years ago

@alxwr, sorry for the slow reaction. Yes, imo we can drop support for the unsupported components. I wouldn't drop nrpe-server and postgresql if still functional. At least the ones in my icinga2 formula are still in use.

alxwr commented 6 years ago

@martinhoefling OK, I'll mark nrpe-server and postgresql as deprecated then with the above links attached and drop the rest. I'm trying to avoid reinventing (and maintaining) the wheel. Rather than a mini-formula for PostgreSQL I'd have a good config example in README.rst.

Thanks for your feedback!

I'll merge after these changes.

alxwr commented 6 years ago

@martinhoefling I'm going to implement an opt-in to use postgres-formula in another PR.