search

saltstack-formulas / influxdb-formula

Installs and configures the InfluxDB timeseries database
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Apache License 2.0
9 stars 34 forks source link

Various fixes and improvements #11

Closed wwentland closed 9 years ago

wwentland commented 9 years ago

There have been some unfortunate errors in the influxdb 0.9 config that are being fixed in this. The last commit also makes it much easier to upgrade from one influxdb version to another.

iggy commented 9 years ago

That's a whole lotta quotes... I was under the impression, one of yaml's strengths was that you didn't need to quote every string under the sun.

wwentland commented 9 years ago

It is, but the interplay between yaml and toml isn't great and I opted for consistency rather than necessity. I believe that only the booleans have to be quoted. I had a short internal debate and decided that I like this style more (dislike the 'salt://....' a little). What's your take on this, @iggy ?

iggy commented 9 years ago

Looks fine. It just seemed like a lot of churn, but I'll buy consistency.