Support newer versions of InfluxDB

saltstack-formulas / influxdb-formula

Installs and configures the InfluxDB timeseries database

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html

Apache License 2.0

9 stars 34 forks source link

Support newer versions of InfluxDB #23

Open sofixa opened 7 years ago

sofixa commented 7 years ago

Hi, nice formula, but newer versions (0.13 + ) don't work due to the fact that they aren't declared in config_defaults.yaml.

It would be nice to add a fallback with some default parameters so there would be no need to update the formula every time there's a new versio on Influx. What do you think?

Cheers, Adrian

n-rodriguez commented 5 years ago

Hello! I'm working on a new version of this formula. It seems that installing/configuring InlfuxDB has changed a lot since 2016 : https://docs.influxdata.com/influxdb/v1.7/introduction/installation/#installing-influxdb-oss. This new formula is almost the same than the telegraf-formula. Maybe we should add semantic-release and then replace the formula (with all the deprecation things)?

n-rodriguez commented 5 years ago

@myii now that semantic-release has been merged, how do we do for the deprecation cycle?

myii commented 5 years ago

@n-rodriguez Generally the same method as the php-formula, in this sort of order (the first two can be merged):

n-rodriguez commented 5 years ago

@myii thank you! but I don't know how it could be applied to this formula since almost everything was in init.sls or config.sls.

myii commented 5 years ago

Is #26 the new v1.0.0?

n-rodriguez commented 5 years ago

Is #26 the new v1.0.0?

yes

myii commented 5 years ago

@n-rodriguez Let's have a last version before the upgrading to v1.0.0, that shows an upcoming deprecation warning. Then we can look at #26.

WarrenWilkinson commented 4 years ago

It looks ilke the last version of influxdb supported is 0.13 from back in 2016, and that big update pull (#26) was not merged.

So... does this repository still have value? I'm asking because I'm unsure if this repo is doing useful work for somebody, or just consuming time for salt maintainers and salt users.

myii commented 4 years ago

It looks ilke the last version of influxdb supported is 0.13 from back in 2016, and that big update pull (#26) was not merged.

So... does this repository still have value? I'm asking because I'm unsure if this repo is doing useful work for somebody, or just consuming time for salt maintainers and salt users.

@WarrenWilkinson If the effort is available to update and maintain this formula, then I'm sure it can have value. The general structure is being maintained, since it was converted to semantic-release. The formula specifics need someone to commit to it, as shown in the CODEOWNERS file.

myii commented 4 years ago

@n-rodriguez Would you mind if someone builds upon the excellent work you provided in #26?

n-rodriguez commented 4 years ago

I'm fine with it

myii commented 4 years ago

I'm fine with it

Thanks, I'll try to get around to it one of these days if no-one else gets there first...

andreimoustache commented 4 years ago

Hey, folks!

Came across this after unsuccessfully trying to use the formula. If I've followed all the PRs and discussions correctly, in order for this formula to work for newer versions, it'd need

a nice, intermediary version with a deprecation warning
the actual changes, which were done for #26 (and for which the fork has gone 🙈 )

Is this right?

PS Thanks for all your great work here! ✌️

myii commented 4 years ago

a nice, intermediary version with a deprecation warning

the actual changes, which were done for #26 (and for which the fork has gone see_no_evil )

Is this right?

@andreimoustache That's right, as I've linked to above in https://github.com/saltstack-formulas/influxdb-formula/issues/23#issuecomment-524638373. Would you be willing to take this on? If so, I've got the commits from the fork that's disappeared, I can push those to my fork so that you could get access to them.

andreimoustache commented 4 years ago

@myii gotcha! I'll sure try to give it a go at some point next week, but I won't make any promises. If you still have access to the work that's been already done and it's relevant, sure, push them, pity if the work goes to waste! Otherwise, still fine!

myii commented 4 years ago

@andreimoustache I found the latest version I had locally and rebased it on the latest version here (note: I haven't checked it any further than this). This is the commit:

https://github.com/myii/influxdb-formula/commit/ea21c93712d8a177b3d98f8ed9085c605d4b6a4b

CC: @n-rodriguez (in case you feel like resurrecting this).

andreimoustache commented 4 years ago

@myii ah wow, you found it, awesome! Unfortunately I haven't had time to go into this, hopefully this weekend. Regardless, it's great that you found it! Thank you!

myii commented 4 years ago

@myii ah wow, you found it, awesome! Unfortunately I haven't had time to go into this, hopefully this weekend. Regardless, it's great that you found it! Thank you!

@andreimoustache Don't thank me too much, it's completely failing in Travis in its current form! Hopefully it isn't too far away from a working solution, though. Or at least an inspiration towards that.

sticky-note commented 1 year ago

@myii @n-rodriguez @andreimoustache What are the news on this ?

andreimoustache commented 1 year ago

@sticky-note Unfortunately, that weekend never came, and I've not touched it.