search

saltstack-formulas / influxdb-formula

Installs and configures the InfluxDB timeseries database
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Apache License 2.0
9 stars 34 forks source link

Add semantic-release #24

Closed n-rodriguez closed 5 years ago

n-rodriguez commented 5 years ago

Before moving to a new implementation of this formula : https://github.com/saltstack-formulas/influxdb-formula/issues/23#issuecomment-524331438

myii commented 5 years ago

@n-rodriguez Happy to review when ready. Please ping me again when it's ready to go.

myii commented 5 years ago

@n-rodriguez Also, would you mind using the latest platform matrix from the template-formula?

aboe76 commented 5 years ago

@n-rodriguez nice work, looking good, the more formulas get semantic release the better.

n-rodriguez commented 5 years ago

@myii @aboe76 I think we're ready to merge :) https://travis-ci.com/saltstack-formulas/influxdb-formula

myii commented 5 years ago

@n-rodriguez Thanks, I'll have a look in the next few hours.

myii commented 5 years ago

@n-rodriguez I left out yamllint changes that are now being used across our semantic-release formulas (see https://github.com/saltstack-formulas/template-formula/pull/159). Shall we leave them for a subsequent PR or are you OK with me adding a commit to this PR?

In terms of test/salt/default/pillar/influxdb.sls, that sort of path is used in a few of our formulas but the majority of our formulas would use test/salt/pillar/influxdb.sls. How do you feel about changing that?

n-rodriguez commented 5 years ago

How do you feel about changing that?

I'm ok with that.

n-rodriguez commented 5 years ago

Shall we leave them for a subsequent PR or are you OK with me adding a commit to this PR?

Feel free to add a commit

saltstack-formulas-travis commented 5 years ago

:tada: This PR is included in version 0.3.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

myii commented 5 years ago

@n-rodriguez It's all merged, thanks for another important PR. I added another commit for yamllint and I also made tiny modifications to the README, so that it matches the template-formula version -- there are some changes that need to be propagated soon, so it makes it easier if everything lines up.