Reload after install, to enable salt.modules.acme.

saltstack-formulas / letsencrypt-formula

Saltstack formula for letsencrypt service

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html

Other

55 stars 151 forks source link

Reload after install, to enable salt.modules.acme. #66

Closed OrangeDog closed 4 years ago

OrangeDog commented 4 years ago

@myii I'd forgotten about this - can you take a look?

myii commented 4 years ago

@OrangeDog Sure. Since @javierbertoli is the global code owner here, let's get an opinion from him first. Would you mind rebasing to fix the conflict and the commit message in the meantime? The proposal looks fine to me.

javierbertoli commented 4 years ago

@OrangeDog, @myii, it LGTM. I think we can merge it one it's rebased.

pull-assistant[bot] commented 4 years ago

Best reviewed: commit by commit

Optimal code review plan

Reload after install, to enable salt.modules.acme. Merge branch 'master' into patch-1

Powered by Pull Assistant. Last update fbcb4b5 ... ff6bd60. Read the comment docs.

myii commented 4 years ago

Thanks for fixing that @OrangeDog, merged with an amended commit message for semantic-release:

fix(install): reload after install, to enable salt.modules.acme

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 0.20.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: