search

saltstack-formulas / letsencrypt-formula

Saltstack formula for letsencrypt service
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
55 stars 151 forks source link

[BUG] post_renew not active when use_package:True #81

Open arthurzenika opened 3 years ago

arthurzenika commented 3 years ago

Your setup

Formula commit hash / release tag

git hash : df1b31e72e14ecbeab11bfe728117b7ed9bbacb0

Pillar / config used

local:
    ----------
    post_renew:
        ----------
        cmds:
            - systemctl reload apache2
    config:
        ----------
        rsa-key-size:
            4096
    domainsets:
        ----------
        www:
            - www.test.localhost
            - test.localhost

Bug details

Describe the bug

post_renew is documented in pillar.example, but seems only used in letsencrypt/files/renew_letsencrypt_cert.sh.jinja which is not deployed when use_package: True (default) is used.

Expected behaviour

Deploy hooks

Attempts to fix the bug

Not yet

Additional context

arthurzenika commented 3 years ago

This might just be a documentation bug, the renew hook might be automatic with certbot plugins.

javierbertoli commented 3 years ago

@arthurlogilab I agree it's a documentation error. I'm using

letsencrypt:
  config:
    deploy-hook = systemctl reload nginx

successfully

heimdull commented 2 years ago

I was just hit with this and should someone not update the piller.example? or maybe fix the state so that it puts what you put in post_renew in renewal-hooks ? following the example currently creates a broken setup IF you are using use_package: True