PR progress checklist (to be filled in by reviewers)
[ ] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed
What type of PR is this?
Primary type
[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[X] [feat] A new feature
[ ] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
Secondary type
[ ] [docs] Documentation changes
[X] [test] Adding missing or correcting existing tests
Does this PR introduce a BREAKING CHANGE?
No.
Related issues and/or pull requests
Fixes #14
Describe the changes you're proposing
Added a couple of extra paramters (letsencrypt:authenticators and letsencrypt:installers) that allow to specify different authenticators or installers for each domainset.
This lets you manage, in a single server, vhosts that authenticate using a local webserver (ie, nginx) and vhosts that authenticate using other methods (ie, route53).
Added a pebble ACME CA to the testing infrastructure, so now we can test that the domainsets are obtained and installed correctly.
Added tests to verify the certificates are obtained and installed correctly.
Pillar / config required to test the proposed changes
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
Fixes #14
Describe the changes you're proposing
Added a couple of extra paramters (
letsencrypt:authenticators
andletsencrypt:installers
) that allow to specify different authenticators or installers for each domainset. This lets you manage, in a single server, vhosts that authenticate using a local webserver (ie, nginx) and vhosts that authenticate using other methods (ie, route53).Added a
pebble
ACME CA to the testing infrastructure, so now we can test that the domainsets are obtained and installed correctly.Added tests to verify the certificates are obtained and installed correctly.
Pillar / config required to test the proposed changes
See https://github.com/saltstack-formulas/letsencrypt-formula/blob/master/test/salt/pillar/domains.sls and https://github.com/saltstack-formulas/letsencrypt-formula/blob/master/pillar.example
Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context