Several bugfixes - Githubissues

saltstack-formulas / librenms-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html

4 stars 9 forks source link

Several bugfixes #7

Closed alxwr closed 5 years ago

alxwr commented 5 years ago

while migrating to Ubuntu 18.04.1 I encountered some bugs and solved them.

Git repo can only be cloned if directory is empty.
Ubuntu uses the librenms user's homedir, so it must be separate from the application's directory.
If a state fails, a re-run shall be triggered on the next Salt run.
setfacl needs package acl on Ubuntu 18.04.1.
LibreNMS still complained about insufficient permissions, so we set them as documented.

kpostrup commented 5 years ago

This looks great! My only complaint is that the librenms user is configured with homedir /home/librenms.

The 'librenms' user is created as a system user account. These would normally not have a homedir in /home/. Instead I think we should set this to /opt/librenms. However I still think it would make sense to have the two vars separated just like you did with home and app_home. For instance if we should support install on different OS (Solaris comes to mind).

alxwr commented 5 years ago

@kpostrup Removed librenms' homedir. @aboe76 @kpostrup I added some adjustments to FreeBSD too:

The name of the ImageMagick port was changed.
setfacl does not work on FreeBSD the way it works on Debian. (I wasn't able to get it to work either.)

Tested on

FreeBSD 11.2
Ubuntu 18.04

alxwr commented 5 years ago

@kpostrup (friendly reminder) Do you approve my changes?

alxwr commented 5 years ago

@aboe76 If there are no further remarks, please merge! :-)

aboe76 commented 5 years ago

@alxwr merged it.

alxwr commented 5 years ago

@aboe76 Thanks for the merge! :-)