search

saltstack-formulas / libvirt-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
19 stars 43 forks source link

formula should also manage libvirtd.conf #16

Closed aboe76 closed 8 years ago

aboe76 commented 8 years ago

It would be nice if the libvirt-formula also manages libvirtd.conf

something like: https://github.com/webscale-formulas/libvirt-formula

gravyboat commented 8 years ago

I'm all for stealing that code if the license permits it.

aboe76 commented 8 years ago

@gravyboat , I think that will be no problem, same license as the salstack-formulas...

aboe76 commented 8 years ago

ok created pull request see #17

gravyboat commented 8 years ago

Looks good to me, my only concern is backwards compatibility as people will have to update some of their stuff. @babilen or @iggy could you weigh in? These changes (in #17) look good to me.

wwentland commented 8 years ago

Agree, merged.