Closed myii closed 4 years ago
Best reviewed: commit by commit
Powered by Pull Assistant. Last update cfde6d9 ... cfde6d9. Read the comment docs.
Comment about the CODEOWNERS
test performed here:
CODEOWNERS
to set @baby-gnu as the global owner:
Also tested with #75 in-between and all picking up fine (for @saltstack-formulas/ssf, without pinging @baby-gnu).
Hey @baby-gnu, thanks for the review. Aren't you going to merge it? I see from the CODEOWNERS
file that you're the only global owner here!!
template
to libvirt
under bin/kitchen converge
[skip ci] (cfde6d9)@myii
Hey @baby-gnu, thanks for the review. Aren't you going to merge it? I see from the
CODEOWNERS
file that you're the only global owner here!!
I was waiting for the tests to finish and I started something else so it took time to come back here ;-)
I was waiting for the tests to finish and I started something else so it took time to come back here ;-)
Actually, I saw another GitHub bot/action available for that, so that you can hit merge and it will do it automatically once the tests complete. Should we enable something like that?
:tada: This PR is included in version 3.7.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
Should we enable something like that?
So the merge is blocked by failing tests? I think it could be a good thing.
So the merge is blocked by failing tests? I think it could be a good thing.
I've collected the list of available GitHub Actions or bots:
We can go through them over time to see which ones we fancy testing.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
Describe the changes you're proposing
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context