saltstack-formulas / libvirt-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
19 stars 43 forks source link

docs(readme): fix `template` to `libvirt` under `bin/kitchen converge` #74

Closed myii closed 4 years ago

myii commented 4 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

pull-assistant[bot] commented 4 years ago
Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     docs(readme): fix `template` to `libvirt` under `bin/kitchen converge`...

Powered by Pull Assistant. Last update cfde6d9 ... cfde6d9. Read the comment docs.

myii commented 4 years ago

Comment about the CODEOWNERS test performed here:

Also tested with #75 in-between and all picking up fine (for @saltstack-formulas/ssf, without pinging @baby-gnu).

myii commented 4 years ago

Hey @baby-gnu, thanks for the review. Aren't you going to merge it? I see from the CODEOWNERS file that you're the only global owner here!!

commit-lint[bot] commented 4 years ago

Documentation

Contributors

@myii

baby-gnu commented 4 years ago

Hey @baby-gnu, thanks for the review. Aren't you going to merge it? I see from the CODEOWNERS file that you're the only global owner here!!

I was waiting for the tests to finish and I started something else so it took time to come back here ;-)

myii commented 4 years ago

I was waiting for the tests to finish and I started something else so it took time to come back here ;-)

Actually, I saw another GitHub bot/action available for that, so that you can hit merge and it will do it automatically once the tests complete. Should we enable something like that?

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 3.7.5 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

baby-gnu commented 4 years ago

Should we enable something like that?

So the merge is blocked by failing tests? I think it could be a good thing.

myii commented 4 years ago

So the merge is blocked by failing tests? I think it could be a good thing.

I've collected the list of available GitHub Actions or bots:

We can go through them over time to see which ones we fancy testing.