Make sure dependencies are installed if required, fix tests

saltstack-formulas / logrotate-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html

Other

23 stars 71 forks source link

Make sure dependencies are installed if required, fix tests #36

Closed javierbertoli closed 5 years ago

javierbertoli commented 5 years ago

PR #34 already found a bug in the service state.

As a follow up, this PR

adds the required dependencies,
checks the correct service for the tested platforms
parallelize travis tests

aboe76 commented 5 years ago

@javierbertoli thanks for this

danny-smit commented 5 years ago

I just noticed this pull request reverted a large part of https://github.com/saltstack-formulas/logrotate-formula/pull/35, which doesn't seem to be intentional (concerning map.jinja which included os specific data from osmap.yaml and osfamilymap.yaml).

Therefore it seems this change breaks added support of gentoo and freebsd of https://github.com/saltstack-formulas/logrotate-formula/pull/35

It that correct?

aboe76 commented 5 years ago

@javierbertoli can you look into this?

javierbertoli commented 5 years ago

@aboe76 sure. Perhaps a missing rebase? I don't recall deleting them. Pushed #37, @danny-smit mind you check if all's OK?

danny-smit commented 5 years ago

I can only visual inspect the change, since I do not depend on the additional code of that was removed myself. However as far as I can tell, it seems to be fine now.

javierbertoli commented 5 years ago

@aboe76 mind you merge?