feat(hourly): Add configuration to enable hourly jobs

mdschmitt commented 2 years ago

PR progress checklist (to be filled in by reviewers)

[ ] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Primary type

[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[x] [feat] A new feature
[ ] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[ ] [docs] Documentation changes
[ ] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

Not unless existing pillar values for clients have "hourly" set in their job configurations. ...in which case, they already don't work straight-out-of-the-box.

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

[ ] Updated the README (e.g. Available states).
[ ] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

Additional context

mdschmitt commented 2 years ago

@myii , how's this look?

mdschmitt commented 2 years ago

No major rush, but any word on this?

mdschmitt commented 2 years ago

@myii , dropping another bump in here. Any feedback on my revisions?

mdschmitt commented 2 years ago

Latest CI failure because ArchLinux properly uses systemd timers rather than cron. Requires deeper code tweakage to properly provide for. This PR on hold until I can get that to be better.

myii commented 2 years ago

@mdschmitt Thanks for the additions. I've tested some changes in my own fork to ensure Arch Linux is working as well. I'll push those here and merge this PR shortly.

One question remains: which reference did you use for the /etc/logrotate.hourly.d/... path? I couldn't find any mention of it in the upstream repo:

https://github.com/logrotate/logrotate/search?q=%22logrotate.hourly.d%22&type=code

saltstack-formulas-travis commented 2 years ago

:tada: This PR is included in version 0.13.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

mdschmitt commented 2 years ago

Wow @myii , thank you so much for doing this. You beat me to writing the kitchen test and I definitely would have ended up rewriting things to allow for Arch. Folding in cron-formula as a dependency is much cleaner though.

As far as the naming for "logrotate.hourly.d", it was just a logical canonicalization of "logrotate.d" with the explicit addition of "hourly" since hourly isn't out-of-the-box functionality. Inspiration taken from https://sleeplessbeastie.eu/2018/07/11/how-to-execute-logrotate-every-hour

myii commented 2 years ago

No problem -- thanks for the reference, @mdschmitt.

saltstack-formulas / logrotate-formula