search

saltstack-formulas / lvm-formula

8 stars 13 forks source link

test(travis): + Basic Travis CI, bugfix & minor update #15

Closed noelmcloughlin closed 5 years ago

noelmcloughlin commented 5 years ago

This PR is relatively minor update doing three good things.

Bug: Some OS rename thin-provisioning-toolspackage to device-mapper-persistent-data. 

                 ID: lvm packages installed
           Function: pkg.installed
               Name: thin-provisioning-tools
             Result: False
            Comment: Error occurred installing package(s). Additional info follows:

              errors:
                  - Running scope as unit: run-rfa821170b6374a3c91ecd1c467648d53.scope
                    Last metadata expiration check: 0:00:26 ago on Sat Sep 21 12:10:05 2019.
                    No match for argument: thin-provisioning-tools
                    Error: Unable to find a match
            Started: 12:10:30.306255
           Duration: 3090.0000000000036 ms

Updated files are-

Tests:; For testing the PR I added basic Travis CI support. See: https://travis-ci.org/noelmcloughlin/lvm-formula/builds/587945263

New files are:

Convention: I renamed all remove.sls files to clean.sls and updated the README accordingly.
For backwards compatibility the remove.sls files invoke the clean state.

This PR introduces NO breaking changes - all good stuff!

aboe76 commented 5 years ago

@noelmcloughlin what a work!! at first glance looking good.

myii commented 5 years ago

@noelmcloughlin Great job, I'll try to review (at least some of) this fairly soon.

myii commented 5 years ago

@noelmcloughlin In terms of the main files we manage leading to semantic-release, I've checked through and added another commit (454f0a1) with the last bits. See if you're happy with it; if not, feel free to remove it. Otherwise, this PR is also semantic-release ready.

Update: I pushed the commit again because I moved the README to the docs/ directory and reformatted it in general, while taking into account both:

noelmcloughlin commented 5 years ago

@thanks @myii, and @aboe76 for reviewing.

Yes adding semantic release makes sense. In this PR I have learned more on Travis CI, and noted the additions required for semantic release.

noelmcloughlin commented 5 years ago

@baby-gnu thanks for the review.

I'd like to raise an new issue for your comments but this repo has issues disabled. Once that is sorted I'll raise that issue. Meanwhile I'll fix the major comment on README. now.

noelmcloughlin commented 5 years ago

Raised #1 and #2

noelmcloughlin commented 5 years ago

Thanks @myii and @baby-gnu for the reviews and comments - appreciated.

saltstack-formulas-travis commented 5 years ago

:tada: This PR is included in version 0.3.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: