search

saltstack-formulas / lvm-formula

8 stars 13 forks source link

Automated testing is failing on this formula #19

Closed myii closed 4 years ago

myii commented 4 years ago

@noelmcloughlin I run weekly tests of all converted formulas against Salt's master branch, as additional QA. The lvm-formula has been passing up until this week:

When it failed this week, I also tested it against 3000.1 as well as 2019.2 but all are failing:

It appears to be the same state failing:

                 ID: lvm_pv_create_/dev/loop4
           Function: lvm.pv_present
               Name: /dev/loop4
             Result: False
            Comment: An exception occurred in this state: Traceback (most recent call last):
                File "/usr/lib/python3/dist-packages/salt/state.py", line 1933, in call
                  **cdata['kwargs'])
                File "/usr/lib/python3/dist-packages/salt/loader.py", line 1951, in wrapper
                  return f(*args, **kwargs)
                File "/usr/lib/python3/dist-packages/salt/states/lvm.py", line 66, in pv_present
                  changes = __salt__['lvm.pvcreate'](name, **kwargs)
                File "/usr/lib/python3/dist-packages/salt/modules/linux_lvm.py", line 255, in pvcreate
                  raise CommandExecutionError(out.get('stderr'))
              salt.exceptions.CommandExecutionError:   WARNING: Failed to connect to lvmetad. Falling back to device scanning.
                Can't open /dev/loop4 exclusively.  Mounted filesystem?

Note, this is also causing the iscsi-formula testing to fail, since it uses the lvm-formula as a dependency.

References:

noelmcloughlin commented 4 years ago

Hi, @myii I'll have a look at this when I get time. I think I recall some issue in the past when trying to guess names of the loop devices. Possibly some Docker container parameter changed. The tests or states may need to be redesigned to remove the guesswork. thanks

noelmcloughlin commented 4 years ago

Hi @Myii

For lvm formula, I raised https://github.com/saltstack-formulas/lvm-formula/pull/20 which hopefully passes tests in future.

For iscsi formula, there is known issue with Linux kernel requiring a reboot on Arch/Centos - this seems impossible to fix in Travis: https://github.com/saltstack-formulas/iscsi-formula/issues/33

On Fri, Apr 17, 2020 at 4:04 PM Imran Iqbal notifications@github.com wrote:

@noelmcloughlin https://github.com/noelmcloughlin I run weekly tests of all converted formulas against Salt's master branch, as additional QA. The lvm-formula has been passing up until this week:

When it failed this week, I also tested it against 3000.1 as well as 2019.2 but all are failing:

It appears to be the same state failing:

             ID: lvm_pv_create_/dev/loop4

       Function: lvm.pv_present

           Name: /dev/loop4

         Result: False

        Comment: An exception occurred in this state: Traceback (most recent call last):

            File "/usr/lib/python3/dist-packages/salt/state.py", line 1933, in call

              **cdata['kwargs'])

            File "/usr/lib/python3/dist-packages/salt/loader.py", line 1951, in wrapper

              return f(*args, **kwargs)

            File "/usr/lib/python3/dist-packages/salt/states/lvm.py", line 66, in pv_present

              changes = __salt__['lvm.pvcreate'](name, **kwargs)

            File "/usr/lib/python3/dist-packages/salt/modules/linux_lvm.py", line 255, in pvcreate

              raise CommandExecutionError(out.get('stderr'))

          salt.exceptions.CommandExecutionError:   WARNING: Failed to connect to lvmetad. Falling back to device scanning.

            Can't open /dev/loop4 exclusively.  Mounted filesystem?

Note, this is also causing the iscsi-formula testing to fail, since it uses the lvm-formula as a dependency.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/saltstack-formulas/lvm-formula/issues/19, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFUUQQRKWKZ5NRZBJI2PPTRNBVWBANCNFSM4MK2D4MA .

myii commented 4 years ago

@noelmcloughlin Nice, I'll try to get around to it soon. Does iscsi work for the other platforms, though?

noelmcloughlin commented 4 years ago

Yes, I fixed Centos. Only arch job is failing for iscsi - trying some things but not promising.

On Sun, Apr 19, 2020 at 3:00 PM Imran Iqbal notifications@github.com wrote:

@noelmcloughlin https://github.com/noelmcloughlin Nice, I'll try to get around to it soon. Does iscsi work for the other platforms, though?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/saltstack-formulas/lvm-formula/issues/19#issuecomment-616141677, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFUUQUF6XKAZUPINVOGDHDRNL7YXANCNFSM4MK2D4MA .

noelmcloughlin commented 4 years ago

PRs raised to fix things: LVM: https://github.com/saltstack-formulas/lvm-formula/pull/20 ISCSI: https://github.com/saltstack-formulas/iscsi-formula/pull/35

saltstack-formulas-travis commented 4 years ago

:tada: This issue has been resolved in version 0.3.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: