container_file_get bugs fixed, boostrap run logic changed from onfail to unless True in marker file (not to produce failed states in the normal workflow)

saltstack-formulas / lxd-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html

Other

21 stars 18 forks source link

container_file_get bugs fixed, boostrap run logic changed from onfail to unless True in marker file (not to produce failed states in the normal workflow) #10

Closed Jetman80 closed 6 years ago

Jetman80 commented 6 years ago

Hi! Usage of onfail prereq produces failed states in a normal workflow. Onfail was changed to unless grep True in the marker file (path chaged to /etc, which I think better suits LFHS). The marker file is being downloaded with container_file_get , which had small bugs.

jochumdev commented 6 years ago

Thanks! I like your changes, especialy the onfail stuff improves my previous work.

jochumdev commented 6 years ago

Please don't forget to star this formula :+1: