saltstack-formulas / maven-formula

A minimalistic way to install just the maven distribution without any dependencies
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
4 stars 10 forks source link

Update to 3.3.9 and enhancements #10

Closed noelmcloughlin closed 7 years ago

noelmcloughlin commented 7 years ago

This PR provides updates to the maven-formula which is bit out of date.
Maven 3.3.9 is much more widely used than latest version (3.5).

Enhancements

Tested Baseline

This snapshot was verified on Ubuntu 16 (earlier cut verified on Fedora 25)

Ubuntu 16.04 AMD Desktop release

Fedora 25 AMD Desktop release

Thanks,

noelmcloughlin commented 7 years ago

Comments on https://github.com/saltstack-formulas/sun-java-formula/pull/32 (contains similar patterns) need review/action before this PR is approved.

noelmcloughlin commented 7 years ago

Implemented the best practice comments from saltstack-formulas/sun-java-formula#32 review in this formula. Tested on Ubuntu 16.04.

Please review and approve if happy. Thanks.

noelmcloughlin commented 7 years ago

@whiteinge Hi Seth, could you get someone to review.

whiteinge commented 7 years ago

@noelmcloughlin looks good, thanks!

noelmcloughlin commented 7 years ago

Thanks @whiteinge