This PR adds an example maven-setttings.xml file to the formula. Maven is quite useless without settings.xml file anyway so this is useful starting point for future idea here. The Jinja template example requires end-user to update two variables in settings.sls.
This PR addresses following issues seen when tested on older Salt version-
Salt 2015.8.8 (Beryllium) generates "Requisite declaration XXXXXXXXXXX in SLS sqlplus is not formed as a single key dictionary" errors on requires-
Solution: Prefix requisite-type to all requires (i.e. - **cmd**: download-maven-archive ).
. Salt generates warnings on Fedora regarding saltstack/salt#39751
Solution: Remove "user: root" and "group: root" from archive.extracted state.
Source_hash handling has issues in salt 2016.11.0 and earlier.
Solution: Only check source_hash on newer Salt version as interim measure. Twooster on #salt IRC suggested "{% if grains['saltversioninfo'] <= [2016, 11, 6] %}" to workaround version-check issue on opensuse/salt 2016.3.
On older Salt version the formula is broken as archive.extracted "name" exists.
Solution: Reintroduce "if_missing" parameter to archive.extracted as recommended solution for older Salt. This fixes formula on old Salt.
Getting "recursive requisite" error on fedora/ubuntu for statename {{ xxxxx }}
Solution: Seemingly fixed by renaming state to avoid ID clash-
-{{ archive_file }}: +maven-remove-prev-archive:
This PR adds an example maven-setttings.xml file to the formula. Maven is quite useless without settings.xml file anyway so this is useful starting point for future idea here. The Jinja template example requires end-user to update two variables in settings.sls.
This PR addresses following issues seen when tested on older Salt version-
Salt 2015.8.8 (Beryllium) generates "Requisite declaration XXXXXXXXXXX in SLS sqlplus is not formed as a single key dictionary" errors on requires-
. Salt generates warnings on Fedora regarding saltstack/salt#39751
Source_hash handling has issues in salt 2016.11.0 and earlier.
On older Salt version the formula is broken as archive.extracted "name" exists.
Getting "recursive requisite" error on fedora/ubuntu for statename {{ xxxxx }}
Solution: Seemingly fixed by renaming state to avoid ID clash-
-{{ archive_file }}: +maven-remove-prev-archive:
Bug in maven.env state: https://github.com/saltstack-formulas/maven-formula/issues/14
Solution: Fixed in this PR
Tested successfuly (no pillars):