feat(formula): align to template formula; add ci tests

noelmcloughlin commented 4 years ago

PR progress checklist (to be filled in by reviewers)

[x] Changes to documentation are appropriate (or tick if not required)
[x] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Primary type

[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[x] [ci] Changes to the continuous integration configuration
[x] [feat] A new feature
[x] [fix] A bug fix
[ ] [perf] A code change that improves performance
[x] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[x] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[x] [docs] Documentation changes
[ ] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

YES

Related issues and/or pull requests

Describe the changes you're proposing

This PR aligns to the Template formula and adds CI/Travis tests.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

[x] Updated the README (e.g. Available states).
[x] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

Additional context

noelmcloughlin commented 4 years ago

Trace on MacOS

local:
----------
          ID: maven-package-archive-clean-file-absent
    Function: file.absent
        Name: /usr/local/apache-maven-3.6.3
      Result: True
     Comment: Removed directory /usr/local/apache-maven-3.6.3
     Started: 20:30:42.995961
    Duration: 20.589 ms
     Changes:   
              ----------
              removed:
                  /usr/local/apache-maven-3.6.3
----------
          ID: maven-package-archive-clean-file-absent
    Function: file.absent
        Name: /usr/local/bin/maven
      Result: True
     Comment: Removed file /usr/local/bin/maven
     Started: 20:30:43.016834
    Duration: 0.69 ms
     Changes:   
              ----------
              removed:
                  /usr/local/bin/maven
----------
          ID: maven-config-clean-file-absent
    Function: file.absent
        Name: /tmp/dummy_list_item
      Result: True
     Comment: File /tmp/dummy_list_item is not present
     Started: 20:30:43.017784
    Duration: 0.398 ms
     Changes:   
----------
          ID: maven-config-clean-file-absent
    Function: file.absent
        Name: /Users/bob/.m2/settings.xml
      Result: True
     Comment: File /Users/bob/.m2/settings.xml is not present
     Started: 20:30:43.018461
    Duration: 0.712 ms
     Changes:   
----------
          ID: maven-config-clean-file-absent
    Function: file.absent
        Name: /etc/defaults/maven.sh
      Result: True
     Comment: File /etc/defaults/maven.sh is not present
     Started: 20:30:43.019491
    Duration: 0.622 ms
     Changes:   
----------
          ID: maven-config-clean-file-absent
    Function: file.absent
        Name: /Users/bob/.m2/archetype-catalog.xml
      Result: True
     Comment: File /Users/bob/.m2/archetype-catalog.xml is not present
     Started: 20:30:43.020385
    Duration: 0.999 ms
     Changes:   
----------
          ID: maven-package-archive-install
    Function: pkg.installed
        Name: curl
      Result: True
     Comment: All specified packages are already installed
     Started: 20:30:49.145278
    Duration: 10812.726 ms
     Changes:   
----------
          ID: maven-package-archive-install
    Function: pkg.installed
        Name: gzip
      Result: True
     Comment: All specified packages are already installed
     Started: 20:30:59.958276
    Duration: 35.178 ms
     Changes:   
----------
          ID: maven-package-archive-install
    Function: file.directory
        Name: /usr/local/apache-maven-3.6.3
      Result: True
     Comment: Directory /usr/local/apache-maven-3.6.3 updated
     Started: 20:30:59.993587
    Duration: 2.203 ms
     Changes:   
              ----------
              /usr/local/apache-maven-3.6.3:
                  New Dir
----------
          ID: maven-package-archive-install
    Function: archive.extracted
        Name: /usr/local/apache-maven-3.6.3
      Result: True
     Comment: http://www.us.apache.org/dist/maven/maven-3/3.6.3/binaries/apache-maven-3.6.3-bin.tar.gz extracted to /usr/local/apache-maven-3.6.3/, due to absence of one or more files/dirs
     Started: 20:30:59.999244
    Duration: 279.205 ms
     Changes:   
              ----------
              extracted_files:
                  - x README.txt
                  - x LICENSE
                  - x NOTICE
                  - x lib/
                  - x lib/cdi-api.license
                  - x lib/commons-cli.license
<CUT>
                  - x lib/plexus-component-annotations.license
                  - x lib/plexus-interpolation.license
                  - x lib/plexus-sec-dispatcher.license
                  - x lib/plexus-utils.license
                  - x lib/slf4j-api.license
                  - x boot/
                  - x boot/plexus-classworlds.license
                  - x lib/jansi-native/
                  - x lib/jansi-native/freebsd32/
<CUT>
                  - x lib/jansi-native/osx/libjansi.jnilib
                  - x lib/jansi-native/windows32/jansi.dll
                  - x lib/jansi-native/windows64/jansi.dll
                  - x bin/m2.conf
                  - x bin/mvn.cmd
                  - x bin/mvnDebug.cmd
                  - x bin/mvn
                  - x bin/mvnDebug
                  - x bin/mvnyjp
                  - x conf/
                  - x conf/logging/
                  - x conf/logging/simplelogger.properties
                  - x conf/settings.xml
                  - x conf/toolchains.xml
                  - x lib/ext/
                  - x lib/jansi-native/
                  - x lib/ext/README.txt
                  - x lib/jansi-native/README.txt
                  - x boot/plexus-classworlds-2.6.0.jar
                  - x lib/maven-embedder-3.6.3.jar
  <CUT?>
                  - x lib/wagon-file-3.3.4.jar
                  - x lib/maven-resolver-connector-basic-1.4.1.jar
                  - x lib/maven-resolver-transport-wagon-1.4.1.jar
                  - x lib/maven-slf4j-provider-3.6.3.jar
                  - x lib/jansi-1.17.1.jar
              updated ownership:
                  True
----------
          ID: maven-archive-install-file-symlink-maven
    Function: file.symlink
        Name: /usr/local/bin/maven
      Result: True
     Comment: Created new symlink /usr/local/bin/maven -> /usr/local/apache-maven-3.6.3//bin/mvn
     Started: 20:31:00.278686
    Duration: 887.977 ms
     Changes:   
              ----------
              new:
                  /usr/local/bin/maven
----------
          ID: maven-config-file-file-managed-environ_file
    Function: file.managed
        Name: /etc/defaults/maven.sh
      Result: True
     Comment: File /etc/defaults/maven.sh updated
     Started: 20:31:01.170012
    Duration: 1633.272 ms
     Changes:   
              ----------
              diff:
                  New file
              group:
                  bob
              mode:
                  0644
              user:
                  bob
----------
          ID: maven-config-file-install-config_managed
    Function: file.managed
        Name: /Users/bob/.m2/settings.xml
      Result: True
     Comment: File /Users/bob/.m2/settings.xml updated
     Started: 20:31:02.803403
    Duration: 22.335 ms
     Changes:   
              ----------
              diff:
                  New file
              group:
                  bob
              mode:
                  0644
              user:
                  bob

Summary for local
-------------
Succeeded: 13 (changed=7)
Failed:     0

pull-assistant[bot] commented 4 years ago

Best reviewed: commit by commit

Optimal code review plan

feat(formula): align to template formula; add ci tests ci(kitchen+travis): use latest pre-salted images

Powered by Pull Assistant. Last update b61f806 ... d5e0663. Read the comment docs.

commit-lint[bot] commented 4 years ago

Features

formula: align to template formula; add ci tests (b24b3eb)

Continuous Integration

archlinux: py2 support removed in salt (6e3524e)

Bug Fixes

arch: fix jinja logic for arch (f1ebc86)

Contributors

@noelmcloughlin

noelmcloughlin commented 4 years ago

Squashed commits

myii commented 4 years ago

Finalised with d5e0663e8e957df3c80527207e417663e8ac34ae, including latest pre-salted images.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

saltstack-formulas / maven-formula