saltstack-formulas / mongodb-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
31 stars 120 forks source link

Re-engineered solution with many new features #51

Closed noelmcloughlin closed 5 years ago

noelmcloughlin commented 6 years ago

This PR is a rewrite to introduce many new features. Resolves#14, #40, #45, #47, #50. Existing pillars for MongoDB 3.0 upwards should work fine; support for older/broken releases is dropped.

VERIFICATION Tested on Centos7. Ubuntu 16.04, and MacOS using use_repo: True and use_archives: True

Logs centos_firewalld_selinuxEnforcing.log macos.log ubuntu.log

CHANGELOG

New features added

deprecated stuff

removed

Not done

javierbertoli commented 6 years ago

Just an initial comment/change request:

s/depreciated/deprecated/g ? :wink:

noelmcloughlin commented 6 years ago

According to online dictionaries both words have same meaning?

deprecate another term for depreciate (sense 2). "he deprecates the value of children's television"

javierbertoli commented 6 years ago

According to online dictionaries both words have same meaning?

deprecate another term for depreciate (sense 2). "he deprecates the value of children's television"

Huh... you're right, didn't know they are synonyms in English. Never saw it used as depreciated in computing, always as deprecated (that's why I mentioned it), and in my language (Spanish) they have different meaning. Oh, well, ignore my comment :smile:

noelmcloughlin commented 6 years ago

No problem, I was not sure myself.

Its fair comment to say deprecated is more common in Computing. I updated the commit. thanks

noelmcloughlin commented 6 years ago

@gtmanfred could you have a look sometime. I would greatly appreciate this. I've heavily tested; If issues emerge, they mine!!

gtmanfred commented 6 years ago

@noelmcloughlin fyi, i am no longer with saltstack, you should request reviews in the #formulas channel on the community slack.

noelmcloughlin commented 5 years ago

Thanks @gtmanfred good luck with the change!!

noelmcloughlin commented 5 years ago

@nmadhok @thatch45 OpenSDS will be supporting MongoDB in their Bali release.

Since this repo is unmaintained, I would be grateful if either of you could review the PR.

The PR is heavily tested.

The repo has not been updated since 2016 so this PR will be improvement, and I will follow up on any technical debt.

noelmcloughlin commented 5 years ago

Thanks @aboe76 and @nmadhok Appreciated.