search

saltstack-formulas / mongodb-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
31 stars 121 forks source link

fix(jinja): fix 'mongodb' not found jinja error #68

Closed noelmcloughlin closed 5 years ago

noelmcloughlin commented 5 years ago

This PR fixes jinja rendering error.

    Rendering SLS 'base:mongodb.compass' failed: Jinja variable 'mongodb' is undefined
/var/cache/salt/minion/files/base/mongodb/oscodemap.yaml(31):
---
[...]

      baseurl: 'https://repo.mongodb.org/yum/redhat/$releasever/mongodb-org/RELEASE/$basearch/'
      name: mongodb-org-RELEASE
      humanname: MongoDB RELEASE Repository
      gpgkey: 'https://www.mongodb.org/static/pgp/server-RELEASE.asc'
      from_repo_value: {{ mongodb.server.repo.name|replace('RELEASE', mongodb.server.version) or None }}    <======================
vandernorth commented 5 years ago

@aboe76 would you be able to merge this? This formula wont run on any machine unfortunately.

noelmcloughlin commented 5 years ago

Thanks @vandernorth If this is okay with you I will just merge this. Do you not have permissions to review/merge? I can get you into contributor group if you want.

vandernorth commented 5 years ago

Would be great if you can merge this. I'm not a contributor, you could add me if you want me to review.

noelmcloughlin commented 5 years ago

thanks @vandernorth for reviewing. Someone in #formulas channel on slack can get you added to saltstsack-fomulas contributors group. I don't have permissions.