saltstack-formulas / mongodb-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
31 stars 121 forks source link

feat(semantic-release): standardise for this formula #79

Closed noelmcloughlin closed 4 years ago

noelmcloughlin commented 4 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

pull-assistant[bot] commented 4 years ago
Score: 0.99

Best reviewed: commit by commit


Optimal code review plan

     feat(semantic-release): standardise for this formula      fix(script): fix some travis tests      docs(readme): add depth one

Powered by Pull Assistant. Last update f56ba6a ... 5680c6b. Read the comment docs.

noelmcloughlin commented 4 years ago

80

noelmcloughlin commented 4 years ago

Merging. Thanks @daks

I will raise a new PR to fix https://github.com/saltstack-formulas/mongodb-formula/pull/60, #70, and #74

myii commented 4 years ago

@noelmcloughlin Appended commit 8f61ecc3fc5a7aaa1c314de04e10262c3c776a7a after checking this with the ssf-formula. Please note the changes.

We've also prepared the 3000.3 images. Please do not update your PRs, since it will be much easier for me to propagate these changes automatically. Just giving you a heads up that this will be happening soon. Feel free to use the new images for new PRs, though.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: