fix(issues): correct various minor issues

noelmcloughlin commented 4 years ago

PR progress checklist (to be filled in by reviewers)

[x] Changes to documentation are appropriate (or tick if not required)
[x] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Primary type

[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[ ] [feat] A new feature
[x] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[ ] [docs] Documentation changes
[x] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Some fixes! Implement https://github.com/saltstack-formulas/mongodb-formula/pull/88 in smaller chunks.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

[ ] Updated the README (e.g. Available states).
[ ] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[x] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

Additional context

pull-assistant[bot] commented 4 years ago

Best reviewed: commit by commit

Optimal code review plan

fix(issues): file various minor issues Merge branch 'master' into one_conf

Powered by Pull Assistant. Last update cf8b457 ... a79bb53. Read the comment docs.

myii commented 4 years ago

@noelmcloughlin Would you mind requesting a review from someone else? I'm in a really busy period and I'll only be holding you up. I still haven't had a chance to go through your prometheus-formula PR.

noelmcloughlin commented 4 years ago

@javierbertoli would you like to review?

noelmcloughlin commented 4 years ago

selfie-merging as this PR is now trivial update.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 1.0.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

saltstack-formulas / mongodb-formula