search

saltstack-formulas / mongodb-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
31 stars 121 forks source link

[fix] debian: remove firewalld from dependencies #92

Closed ze42 closed 3 years ago

ze42 commented 3 years ago

Sorry, but not everyone uses firewalld, installing it if firewall is handled any other way is a security risk.

It would still be explicitly installed and configured if firewall pillar are configured.

What type of PR is this?

Remote firewalld from prereq on Debian

Does this PR introduce a BREAKING CHANGE?

Might break deployment that rely on the formula to install firewalld. Would not break any running host.

Can configuring it explicitly in pillars still allow to install it.

Related issues and/or pull requests

Fixes https://github.com/saltstack-formulas/mongodb-formula/issues/91

Tested on Debian only.

noelmcloughlin commented 3 years ago

Can you fix commit message https://www.conventionalcommits.org/en/v1.0.0/#summary

ze42 commented 3 years ago

So, commits should start with fix: ?

noelmcloughlin commented 3 years ago

I use "bla1(bla2): bla bla bla" format, the value for "bla1" is important. See https://github.com/saltstack-formulas/.github/blob/master/CONTRIBUTING.rst#commit-message-formatting

myii commented 3 years ago

Merged, thanks for the fix, @ze42. Appreciate the review, @noelmcloughlin.

saltstack-formulas-travis commented 3 years ago

:tada: This PR is included in version 1.0.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: