saltstack-formulas / mongodb-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
31 stars 121 forks source link

fix(repo): do not override service from package #98

Closed ze42 closed 2 years ago

ze42 commented 2 years ago

Package probably provide a valid service, with proper service path. Do not overwrite it.

Note: the version that would be written uses path build with /usr/local and minor version directory, while package (on Debian) tend to install in /bin or /usr/bin, ...

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

When installing mongodb from repository (with a package), that package already provides services with proper path.

That MR prevents the formula from breaking those services with different path not matching the installed binaries, ...

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

Tested on Debian, not tested on other systems.

noelmcloughlin commented 2 years ago

LGTM thanks!

saltstack-formulas-travis commented 2 years ago

:tada: This PR is included in version 1.1.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: