Hugepages

[ze42]

PR progress checklist (to be filled in by reviewers)

• [ ] Changes to documentation are appropriate (or tick if not required)
• [ ] Changes to tests are appropriate (or tick if not required)
• [ ] Reviews completed

---

What type of PR is this?

Primary type

• [ ] [build] Changes related to the build system
• [ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
• [ ] [ci] Changes to the continuous integration configuration
• [ ] [feat] A new feature
• [x] [fix] A bug fix
• [ ] [perf] A code change that improves performance
• [ ] [refactor] A code change that neither fixes a bug nor adds a feature
• [ ] [revert] A change used to revert a previous commit
• [ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

• [ ] [docs] Documentation changes
• [ ] [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Fix disable_transparent_hugepages

• Propery do nothing if set to False
• Enable service on boot
• Launch cmd only if not already set

Pillar / config required to test the proposed changes

Could be tested with and without:

mongodb:
  wanted:
    disable_transparent_hugepages: false

Debug log showing how the proposed changes work

Documentation checklist

• [ ] Updated the README (e.g. Available states).
• [ ] Updated pillar.example.

Testing checklist

• [ ] Included in Kitchen (i.e. under state_top).
• [ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
• [ ] Updated the relevant test pillar.

Additional context

[noelmcloughlin]

ping @ze42

[myii]

Hi @ze42 thanks for PR. Could you get CI working for Arch, probably by updating osfamillymap to avoid triggering the code?

This appears to be relevant:

• https://wiki.archlinux.org/title/MongoDB#Warning_about_Transparent_Huge_Pages_(THP)

[daks]

The THP feature is not specifically targeted at MongoDB but it's a kernel feature which can affect a lot of other things, shouldn't it be managed elsewhere, in another state or formula?

(we use it for Redis and manage it separately in a file.managed state)

[ze42]

still some problem with rubocop, but I don't have any idea what it is about.